Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run CI on canary #713

Closed
wants to merge 1 commit into from
Closed

chore: run CI on canary #713

wants to merge 1 commit into from

Conversation

iuioiua
Copy link

@iuioiua iuioiua commented Sep 3, 2024

This PR enables Deno canary in CI, which currently is the same as enabling Deno 2.0.0-rc.0. This has the obvious benefit of future-proofing this package for Deno 2, but also gives us (Deno) early insight into any issues that users may run into when migrating from Deno 1 to 2.

@panva
Copy link
Owner

panva commented Sep 3, 2024

Hi @iuioiua

I would add v2.x stable when it releases. Unstable releases would need continue-on-error so that I am not bombarded by notifications from, well, unstable releases, which kinda defeats the point you're making.

issues that users may run into when migrating from Deno 1 to 2

jose for Deno only uses Web Platform APIs, if there are breakages in those then failing WPTs will present themselves.

If you want early insight into Deno's popular packages and include jose, all you have to do in Deno's CI, or something similar to Node's CITGM, is

  • fetch the latest tag (those contain a dist folder)
  • npm install (to get some of the test suite's dependencies)
  • run the tap:deno package.json script

@panva panva closed this Sep 3, 2024
@iuioiua iuioiua deleted the canary branch September 3, 2024 10:16
@iuioiua
Copy link
Author

iuioiua commented Sep 3, 2024

No stress 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants