Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Pipe LineOriented through the Console #7723

Conversation

blorente
Copy link
Contributor

Problem

LineOriented is a nice utility to mix options with the console, but unfortunately it writes directly to std{out,err} after grabbing them from the Console. Ideally, we would like all output to go through the Console class, to make things like the UI easier to develop.

Solution

  • Enhance print_std{out,err} in Console to accept a separator.
  • Refactor LineOriented a bit to only write to raw files when we are not writing to stdout.

Result

There should be no visible change in behavior.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements all around. Thanks Borja!

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie. Thanks!

@blorente blorente merged commit 4475fec into pantsbuild:master May 15, 2019
@stuhood stuhood added the ui label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants