[v2] Pipe LineOriented through the Console #7723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LineOriented
is a nice utility to mix options with the console, but unfortunately it writes directly tostd{out,err}
after grabbing them from theConsole
. Ideally, we would like all output to go through theConsole
class, to make things like the UI easier to develop.Solution
print_std{out,err}
inConsole
to accept a separator.LineOriented
a bit to only write to raw files when we are not writing to stdout.Result
There should be no visible change in behavior.