-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.17.0.dev0 release #7711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues with broken rendering probably, but otherwise should be good to go.
src/python/pants/notes/master.rst
Outdated
|
||
* Refactor `PythonSetup.interpreter_or_constraints()` to take a `compatibility` value rather than a `PythonTarget`(#7691) | ||
`PR #7691 <https://github.com/pantsbuild/pants/pull/7691>`_ | ||
`PR #files#diff-04a0048c70898e46a42c73225c47b906R58 <https://github.com/pantsbuild/pants/pull/7679/files#diff-04a0048c70898e46a42c73225c47b906R58>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is probably broken.
src/python/pants/notes/master.rst
Outdated
|
||
* Convert `check_banned_imports.sh` to Python to workaround Bash array issues and for less duplication (#7702) | ||
`PR #7702 <https://github.com/pantsbuild/pants/pull/7702>`_ | ||
>`_ttps://github.com/pantsbuild/pants/pull/7698#discussion_r282947998. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken probably.
src/python/pants/notes/master.rst
Outdated
New Features | ||
~~~~~~~~~~~~ | ||
|
||
* V2 `./pants test.pytest` selects interpreter based off of compatibility constraints (#7679) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuhood is this a bug fix or new feature? It is new behavior, but really it's playing catch up to V1 test.pytest
so in some ways is fixing things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either bugfix or refactor probably. But there is minimal value in being super precise in the categorization of release notes currently.
src/python/pants/notes/master.rst
Outdated
Bugfixes | ||
~~~~~~~~ | ||
|
||
* Mark build-support Python files as Pants targets to lint build-support (#7633) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a refactor.
src/python/pants/notes/master.rst
Outdated
* Fix dependency cycle with cache folder (#7693) | ||
`PR #7693 <https://github.com/pantsbuild/pants/pull/7693>`_ | ||
|
||
* Add pantsd_invalidation_globs option into pants.ini (#7705) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's a bug fix, it only impacts our own pants.ini
so I would suggest moving it to tooling.
src/python/pants/notes/master.rst
Outdated
* PosixFS no longer has its own threadpool (#7685) | ||
`PR #7685 <https://github.com/pantsbuild/pants/pull/7685>`_ | ||
|
||
* Use global instance of PythonSetup for resolve requirements task base (#7672) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a bugfix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As discussed over Slack, will be merging #7699 in about 5 minutes upon green CI if you want to incorporate that (no worries if not).
Problem
Weekly dev release - https://www.pantsbuild.org/release.html