-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: reduction operations failing if min_count
is larger
#40143
REGR: reduction operations failing if min_count
is larger
#40143
Conversation
i'll add a test and whatsnew shortly, if we want to go this route for backport purposes. This fix does not have much value in isolation as the regression #39738 (comment) is not yet addressed here. |
The regression this fixes is caused by
in pandas/core/internals/blocks.py this does not account for the fact that
I still need to track down the earlier regression, where min_count above the row/column length but below the 2d shape does not work as intended, i.e. does nothing |
i don't think we should block on this for 1.2.3. This patch may involve some non-trivial work. |
sure. a 1.2.4 milestone has been created. easily moved. |
great just don't want to block (and i don't see anything urgent to prevent release). |
I was thinking maybe wait till #40144 is fixed. also affects backport. but we will likely have another release before the np-dev issues cause mainstream issues. |
cool |
this seems to be a long standing behavior. This seems non-intuitive to me since I expected min_count to apply column-wise/row-wise if axis is specified. |
…ons-failing-if-`min_count`-is-larger
…ons-failing-if-`min_count`-is-larger
thanks @simonjayhawkins its possible we want to refactor this for 1.3, but for later, cc @jbrockmendel |
@meeseeksdev backport 1.2.x |
…min_count` is larger
…g if `min_count` is larger) (#40237) Co-authored-by: Simon Hawkins <[email protected]>
min_count
is larger #39738