Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: assorted cleanups #29232

Merged
merged 14 commits into from
Oct 29, 2019
Merged

CLN: assorted cleanups #29232

merged 14 commits into from
Oct 29, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this. Could maybe add return types

pandas/_libs/index.pyx Outdated Show resolved Hide resolved
@WillAyd WillAyd added the Clean label Oct 28, 2019
@jbrockmendel
Copy link
Member Author

Thoughts here? I'd like to get this done for pushing the next "assorted cleanups" branch

@jreback jreback added this to the 1.0 milestone Oct 29, 2019
@jreback jreback merged commit 26cd577 into pandas-dev:master Oct 29, 2019
@jreback
Copy link
Contributor

jreback commented Oct 29, 2019

lgtm. thanks @jbrockmendel

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel jbrockmendel deleted the clnmore branch April 5, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants