Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Cannot create third-party ExtensionArrays for datetime types #34986

Closed
2 of 3 tasks
xhochy opened this issue Jun 25, 2020 · 3 comments · Fixed by #34987 or #48640
Closed
2 of 3 tasks

BUG: Cannot create third-party ExtensionArrays for datetime types #34986

xhochy opened this issue Jun 25, 2020 · 3 comments · Fixed by #34987 or #48640
Labels
Bug ExtensionArray Extending pandas with custom dtypes or arrays. Regression Functionality that used to work in a prior pandas version Timestamp pd.Timestamp and associated methods Timezones Timezone data dtype
Milestone
2.0

Comments

@xhochy
Copy link
Contributor

xhochy commented Jun 25, 2020 •
edited
Loading

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.

Code Sample: #34987

Problem description

With #33400 type checks now fasttrack on the kind of the dtype. Thus for every ExtensionDtype that is of kind M, is_datetime64tz_dtype returns True. This is then used in get_block_type which leads to the usage of DatetimeTZBlock for all of these arrays although this block only supports DatetimeArray.

pandas/pandas/core/internals/blocks.py

Lines 2685 to 2690 in 4f7d8bb

elif is_datetime64tz_dtype(values.dtype):
cls = DatetimeTZBlock
elif is_interval_dtype(dtype) or is_period_dtype(dtype):
cls = ObjectValuesExtensionBlock
elif is_extension_array_dtype(values.dtype):
cls = ExtensionBlock

@xhochy xhochy added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 25, 2020
@xhochy xhochy mentioned this issue Jun 25, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel added the ExtensionArray Extending pandas with custom dtypes or arrays. label Sep 3, 2020
@TomAugspurger TomAugspurger removed the Needs Triage Issue that has not been reviewed by a pandas team member label Sep 4, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Dec 6, 2020
Closed
@simonjayhawkins simonjayhawkins added the Regression Functionality that used to work in a prior pandas version label Dec 6, 2020
@jreback jreback added this to the 1.3 milestone Jan 14, 2021
@mroeschke
Copy link
Member

I ran into this in #47515

Since #34987, just added some unit tests, I think this behavior should still be fixed so reopening.

@mroeschke mroeschke reopened this Jun 27, 2022
@mroeschke mroeschke added Timezones Timezone data dtype Timestamp pd.Timestamp and associated methods labels Jun 27, 2022
@mroeschke mroeschke mentioned this issue Aug 25, 2022
Closed
4 tasks
@jbrockmendel
Copy link
Member

@mroeschke will this be fixed by your is_datetime64tz_dtype PR?

@mroeschke
Copy link
Member

I did refactor my original is_datetime64tz_dtype PR #48258 to only be a unit test since I think another one of your PRs fixed the original issue, but can open a separate PR to reintroduce the fix

@mroeschke mroeschke removed this from the 1.3 milestone Sep 19, 2022
@mroeschke mroeschke mentioned this issue Sep 19, 2022
Merged
4 tasks
@phofl phofl added this to the 1.6 milestone Sep 19, 2022
@mroeschke mroeschke mentioned this issue Oct 7, 2022
Merged
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug ExtensionArray Extending pandas with custom dtypes or arrays. Regression Functionality that used to work in a prior pandas version Timestamp pd.Timestamp and associated methods Timezones Timezone data dtype
Projects
None yet
Milestone
2.0
7 participants
@xhochy @jreback @TomAugspurger @jbrockmendel @mroeschke @simonjayhawkins @phofl