Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: use ensure_clean rather than explicit os.remove #34384

Closed
jreback opened this issue May 26, 2020 · 2 comments · Fixed by #34385
Closed

TST: use ensure_clean rather than explicit os.remove #34384

jreback opened this issue May 26, 2020 · 2 comments · Fixed by #34385
Assignees
@jnecus
Labels
good first issue IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented May 26, 2020 

~/pandas-dev$ grep -r os.remove pandas/tests/
pandas/tests/io/excel/test_openpyxl.py:    os.remove(filename)
pandas/tests/io/excel/test_writers.py:    #     os.remove(filename)
pandas/tests/io/excel/test_writers.py:    #     os.remove(filename)
pandas/tests/io/pytables/common.py:            os.remove(path)

we should also create a rule in code_checks.sh to avoid doing this in the future
@jreback jreback added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel good first issue labels May 26, 2020
@jreback jreback added this to the Contributions Welcome milestone May 26, 2020
@jnecus
Copy link
Contributor

jnecus commented May 26, 2020

take

jnecus pushed a commit to jnecus/pandas that referenced this issue May 26, 2020
use ensure_clean rather than explicit os.remove pandas-dev#34384
38aefad 
I have made a start at this issue pandas-dev#34384. Please let me know if I am along the right lines (beginner contributor).

I've left a space in code_checks.sh where I expect to implement the check for instances of 'os.remove' throughout the code.
@jnecus jnecus mentioned this issue May 26, 2020
Merged
jnecus pushed a commit to jnecus/pandas that referenced this issue May 26, 2020
use ensure_clean rather than explicit os.remove pandas-dev#34384
df79c64
@phs-sakshi
Copy link

Can I take up this issue?

@dsaxton dsaxton mentioned this issue Sep 16, 2020
Merged
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Oct 12, 2020
jreback pushed a commit that referenced this issue Oct 12, 2020
@jnecus
use ensure_clean rather than explicit os.remove #34384 (#34385)
a470a63
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Oct 26, 2020
@jnecus @JulianWgs
use ensure_clean rather than explicit os.remove pandas-dev#34384 (pan…
dd393d0 
…das-dev#34385)
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@jnecus
use ensure_clean rather than explicit os.remove pandas-dev#34384 (pan…
7741519 
…das-dev#34385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnecus jnecus

Labels
good first issue IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

use ensure_clean rather than explicit os.remove #34384 jnecus/pandas
3 participants
@jreback @jnecus @phs-sakshi