Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that Pandas 0.25.2 should be compatible with Python 3.8 #28147

Closed
TomAugspurger opened this issue Aug 26, 2019 · 5 comments · Fixed by #28982 · May be fixed by lizsaret/pandas#1
Closed

Document that Pandas 0.25.2 should be compatible with Python 3.8 #28147

TomAugspurger opened this issue Aug 26, 2019 · 5 comments · Fixed by #28982 · May be fixed by lizsaret/pandas#1
Labels
Docs
Milestone
0.25.2

Comments

@TomAugspurger
Copy link
Contributor

#28101 gets things passing with Python 3.8 locally.

Ideally, we'd have 3.8 actually tested on CI before releasing 0.25.2. Hopefully once conda-forge/python-feedstock#271 is up, we can do that (and maybe build our deps from source).

Once we're tested, we should add a note to the whatsnew saying that pandas 0.25.2 is compatible with Python 3.8
@TomAugspurger TomAugspurger added this to the 0.25.2 milestone Aug 26, 2019
@TomAugspurger TomAugspurger changed the title Document that Pandas 0.25.2 should be compatible with Document that Pandas 0.25.2 should be compatible with Python 3.8 Aug 26, 2019
@shafaypro
Copy link

shafaypro commented Aug 27, 2019 •
edited

GG mate, Yes Indeed.

@TomAugspurger
Copy link
Contributor Author

Reran with Python 3.8b4. Things seem OK, but a bunch of plotting tests are failing.

@lizsaret
Copy link
Contributor

lizsaret commented Sep 6, 2019

@TomAugspurger can i work on this?

@lizsaret lizsaret mentioned this issue Sep 6, 2019
Open
5 tasks
@TomAugspurger
Copy link
Contributor Author

This is currently blocked by conda-forge/python-feedstock#271. I'm a bit hesitant to state that we're 3.8 compatible until we're actually testing on CI.

@jreback
Copy link
Contributor

jreback commented Sep 6, 2019

agreed we have no testing on 3.8 yet

@TomAugspurger TomAugspurger mentioned this issue Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.25.2
4 participants
@jreback @TomAugspurger @shafaypro @lizsaret