Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showbase: Annotate basic ShowBase setup/shutdown methods #1558

Merged
merged 6 commits into from
Oct 24, 2024
Merged

showbase: Annotate basic ShowBase setup/shutdown methods #1558

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
48f8587
showbase: Add type annotations to `ShowBase.__init__`
WMOkiishi Oct 19, 2023
c52e1d2
showbase: Annotate other `ShowBase` setup methods
WMOkiishi Oct 19, 2023
2ee2f0c
showbase: Annotate functions for `ShowBase` shutdown
WMOkiishi Oct 21, 2023
d8d077b
Correct an import
WMOkiishi Oct 27, 2023
11a1406
Correct an annotation
WMOkiishi Oct 27, 2023
f7f8ba3
Type `builtins` to allow arbitrary attributes
WMOkiishi Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct an annotation
  • Loading branch information
@WMOkiishi
WMOkiishi committed Oct 27, 2023
commit 11a140686430db34e02265f5d64e63ced564cff1
2 changes: 1 addition & 1 deletion direct/src/showbase/ShowBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 380,7 @@ def __init__(self, fStartDirect: bool = True, windowType: str | None = None) ->
self.shadowTrav: CollisionTraverser | Literal[0] = 0
self.cTravStack = Stack()
# Ditto for an AppTraverser.
self.appTrav: CollisionTraverser | Literal[0] = 0
self.appTrav: Any | Literal[0] = 0

# This is the DataGraph traverser, which we might as well
# create now.
Expand Down