Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI step with fully updated dependencies #118

Merged
merged 3 commits into from
Nov 2, 2024
Merged

CI step with fully updated dependencies #118

merged 3 commits into from
Nov 2, 2024

Conversation

palfrey
Copy link
Owner

@palfrey palfrey commented Nov 2, 2024

No description provided.

@palfrey palfrey merged commit 6229fac into main Nov 2, 2024
8 checks passed
@palfrey palfrey deleted the proc-macro-update branch November 2, 2024 18:59
This was referenced Nov 2, 2024
Closed
Closed
@vsirivol
Copy link
Contributor

vsirivol commented Nov 2, 2024 •
edited
Loading

Doesn't look like the workflow step has executed as the Cargo.lock file has proc-marco2 still is at version = "1.0.71". Is it possible for you take a look at this please.

The following are the packages that need to be updated.

serial_test % cargo update
    Updating crates.io index
     Locking 90 packages to latest compatible versions
    Updating actix-macros v0.2.3 -> v0.2.4
    Updating actix-rt v2.8.0 -> v2.10.0
      Adding addr2line v0.24.2
      Adding adler2 v2.0.0
    Updating aho-corasick v1.1.2 -> v1.1.3
      Adding anstream v0.6.17
      Adding anstyle v1.0.10
      Adding anstyle-parse v0.2.6
      Adding anstyle-query v1.1.2
      Adding anstyle-wincon v3.0.6
    Updating autocfg v1.1.0 -> v1.4.0
      Adding backtrace v0.3.74
    Removing bitflags v1.3.2
    Removing bitflags v2.4.1
      Adding bitflags v2.6.0
    Updating bumpalo v3.12.0 -> v3.16.0
      Adding cc v1.1.34
      Adding colorchoice v1.0.3
    Updating document-features v0.2.7 -> v0.2.10
    Updating either v1.8.1 -> v1.13.0
      Adding env_filter v0.1.2
    Updating env_logger v0.10.1 -> v0.11.5
    Removing errno v0.3.8
    Updating futures v0.3.27 -> v0.3.31
    Updating futures-channel v0.3.27 -> v0.3.31
    Updating futures-core v0.3.27 -> v0.3.31
    Updating futures-executor v0.3.27 -> v0.3.31
    Updating futures-io v0.3.27 -> v0.3.31
    Updating futures-sink v0.3.27 -> v0.3.31
    Updating futures-task v0.3.27 -> v0.3.31
    Updating futures-util v0.3.27 -> v0.3.31
      Adding gimli v0.31.1
    Updating hermit-abi v0.3.3 -> v0.3.9 (latest: v0.4.0)
    Removing is-terminal v0.4.10
      Adding is_terminal_polyfill v1.70.1
    Updating itertools v0.10.5 -> v0.13.0
    Updating js-sys v0.3.61 -> v0.3.72
    Updating libc v0.2.151 -> v0.2.161
    Removing linux-raw-sys v0.4.12
    Updating litrs v0.2.3 -> v0.4.1
    Updating lock_api v0.4.9 -> v0.4.12
    Updating log v0.4.20 -> v0.4.22
    Updating memchr v2.7.1 -> v2.7.4
      Adding minicov v0.3.6
      Adding miniz_oxide v0.8.0
    Updating mio v0.8.11 -> v1.0.2
      Adding object v0.36.5
    Updating once_cell v1.19.0 -> v1.20.2
    Updating parking_lot v0.12.1 -> v0.12.3
    Updating parking_lot_core v0.9.7 -> v0.9.10
    Updating pin-project-lite v0.2.9 -> v0.2.15
    Updating prettyplease v0.2.15 -> v0.2.25
    Updating proc-macro2 v1.0.71 -> v1.0.89
    Updating quote v1.0.30 -> v1.0.37
    Updating redox_syscall v0.2.16 -> v0.5.7
    Updating regex v1.10.2 -> v1.11.1
    Updating regex-automata v0.4.3 -> v0.4.8
    Updating regex-syntax v0.8.2 -> v0.8.5
      Adding rustc-demangle v0.1.24
    Removing rustix v0.38.28
      Adding same-file v1.0.6
    Updating scc v2.0.18 -> v2.2.4
    Updating scoped-tls v1.0.0 -> v1.0.1
    Updating scopeguard v1.1.0 -> v1.2.0
      Adding sdd v3.0.4
      Adding shlex v1.3.0
    Updating signal-hook-registry v1.4.1 -> v1.4.2
    Updating slab v0.4.8 -> v0.4.9
    Updating smallvec v1.10.0 -> v1.13.2
    Updating socket2 v0.4.9 -> v0.5.7
    Removing syn v1.0.109
    Removing syn v2.0.43
      Adding syn v2.0.87
    Removing termcolor v1.4.0
    Updating tokio v1.27.0 -> v1.41.0
    Updating tokio-macros v2.0.0 -> v2.4.0
    Updating unicode-ident v1.0.8 -> v1.0.13
      Adding utf8parse v0.2.2
      Adding walkdir v2.5.0
    Updating wasm-bindgen v0.2.84 -> v0.2.95
    Updating wasm-bindgen-backend v0.2.84 -> v0.2.95
    Updating wasm-bindgen-futures v0.4.34 -> v0.4.45
    Updating wasm-bindgen-macro v0.2.84 -> v0.2.95
    Updating wasm-bindgen-macro-support v0.2.84 -> v0.2.95
    Updating wasm-bindgen-shared v0.2.84 -> v0.2.95
    Updating wasm-bindgen-test v0.3.34 -> v0.3.45
    Updating wasm-bindgen-test-macro v0.3.34 -> v0.3.45
    Updating web-sys v0.3.61 -> v0.3.72
    Updating winapi-util v0.1.6 -> v0.1.9
    Removing windows-sys v0.45.0
    Removing windows-sys v0.48.0
      Adding windows-sys v0.59.0
    Removing windows-targets v0.42.2
    Removing windows-targets v0.48.5
    Removing windows-targets v0.52.0
      Adding windows-targets v0.52.6
    Removing windows_aarch64_gnullvm v0.42.2
    Removing windows_aarch64_gnullvm v0.48.5
    Removing windows_aarch64_gnullvm v0.52.0
      Adding windows_aarch64_gnullvm v0.52.6
    Removing windows_aarch64_msvc v0.42.2
    Removing windows_aarch64_msvc v0.48.5
    Removing windows_aarch64_msvc v0.52.0
      Adding windows_aarch64_msvc v0.52.6
    Removing windows_i686_gnu v0.42.2
    Removing windows_i686_gnu v0.48.5
    Removing windows_i686_gnu v0.52.0
      Adding windows_i686_gnu v0.52.6
      Adding windows_i686_gnullvm v0.52.6
    Removing windows_i686_msvc v0.42.2
    Removing windows_i686_msvc v0.48.5
    Removing windows_i686_msvc v0.52.0
      Adding windows_i686_msvc v0.52.6
    Removing windows_x86_64_gnu v0.42.2
    Removing windows_x86_64_gnu v0.48.5
    Removing windows_x86_64_gnu v0.52.0
      Adding windows_x86_64_gnu v0.52.6
    Removing windows_x86_64_gnullvm v0.42.2
    Removing windows_x86_64_gnullvm v0.48.5
    Removing windows_x86_64_gnullvm v0.52.0
      Adding windows_x86_64_gnullvm v0.52.6
    Removing windows_x86_64_msvc v0.42.2
    Removing windows_x86_64_msvc v0.48.5
    Removing windows_x86_64_msvc v0.52.0
      Adding windows_x86_64_msvc v0.52.6
note: pass `--verbose` to see 2 unchanged dependencies behind latest

@palfrey
Copy link
Owner Author

palfrey commented Nov 2, 2024

The workflow step has executed, and it's working as planned. All it does is upgrade the Cargo.lock locally and check (via build/test) that none of the upgrades break anything.

The crate files that other projects use does not include this Cargo.lock at all. It's contents are irrelevant from the PoV of users of this crate. The only reason to have it committed is so we have a stable set of libraries to run tests against. What that means that if an upgrade breaks stuff the new step will fail, but the others will be fine, and that tells me an upgrade breaks stuff.

Now, if you've got another project that uses serial_test the requirements of this crate require proc-macro2 of at least 1.0.60 as a dependency, and this CI step checks that the most recent ones are also fine (note the Updating proc-macro2 v1.0.71 -> v1.0.89). If you're running something else that wants proc-macro2 of at least 1.0.89, that's all fine, you declare that requirement there not here.

@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palfrey @vsirivol