Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests and fix edge case with GitHub redirection #874

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Dec 11, 2024

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes

Related to #781
Related to packit/packit-service#2670

@mfocko mfocko self-assigned this Dec 11, 2024
Copy link
Contributor

mfocko added 3 commits January 2, 2025 09:55
During the investigation of another issue it appeared that it could be
caused by parsing in the ogr, but adding the test here didn't reveal
anything. Adding the test, just in case, as a part of the regression test
 suite, in case the issue could reappear here sometimes in the future.

Related to packit/packit-service#2670

Signed-off-by: Matej Focko <[email protected]>
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Jan 2, 2025
Copy link
Contributor

@mfocko
Copy link
Member Author

mfocko commented Jan 2, 2025

/packit test

@mfocko mfocko added mergeit When set, zuul wil gate and merge the PR. and removed mergeit When set, zuul wil gate and merge the PR. labels Jan 2, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/80153432819c40018092adbcd1d148e0

✔️ pre-commit SUCCESS in 2m 31s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3efeffa into packit:main Jan 2, 2025
27 of 30 checks passed
@mfocko mfocko deleted the fix/redirect branch January 2, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants