-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample
test case is broken with 1.75
#230
Comments
It looks like |
Interestingly enough it works on my machine with 1.75.0
Can you try passing |
Stripping shouldn't affect anything - c-s-a doesn't run on compiled code, it asks rustc to dump generated |
Can you try building it with --no-default-features on By stripping I've meant dead code elimination, maybe there's now a MIR optimization that removes |
I have a hunch, will try that in the morning though; |
works for me... CI seem to detect it when it's there if I run with no argument... But fails to find it when it's called.
I'll poke around, will let you know if I manage to reproduce it. |
Well, IMHO the return value should make a difference as to whether the code is stripped altogether or not. |
Can you attach the raw |
It is in original post in a .zip, together with .s for 1.73. |
Okay, got the jackpot. The return value was indeed not an issue. |
Good catch! |
Closing as it's fixed with e7e31ac71fdc8d350226a39ac2be5a4a47c6bac0 |
In PR #229 we started seeing weird CI failures for
cargo-show-asm/.github/workflows/check-and-lint.yaml
Line 40 in 8955190
Attached is the old output of the failing test and a new one. Note that the base is 1.73 and not 1.74, though it doesn't seem to make much of a difference.
cargo-show-asm-1-75-ci-failure.zip
The text was updated successfully, but these errors were encountered: