Do not recompute write sets for equal child nodes belonging to a given IR::Vector
#4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2024
|
See #4811 |
fruffy
added
the
core
…ctors Signed-off-by: Kyle Cripps <[email protected]>
kfcripps
force-pushed
the
simplify-def-use-context-2
branch
from
b8d1d8e
to
7d80973
Compare
|
Not particularly fond of this API. Seems built just to hide this particular bug. |
|
@mihaibudiu By API do you mean Also, this PR is not "hiding" any bug. It is one of several steps needed to fix the root problem that has been previously discussed. |
|
This is @ChrisDodd's territory, so he should decide the fate of this API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on top of #4797
Title and discussion in #4797 are self-explanatory.
This still does not fully fix the problem described in #4797 (but it is yet another incremental improvement).
ComputeWriteSet'scallingContextis not properly updated during the IR traversal, soProgramPoints are not correct in many places. This can be fixed by either:ComputeWriteSet'scallingContextis properly updated andProgramPoints created correctly everywhere, orProgramPoints withloc_t, so that updating the calling context is the responsibility of theVisitoroverhead, rather than ofComputeWriteSet.Neither of these are trivial, but the latter is probably the most invasive option.