Compilation test support for P4Smith #4791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzmic
force-pushed
the
compilation-test-support
branch
from
b3cf81e
to
d34f60e
Compare
zzmic
force-pushed
the
compilation-test-support
branch
3 times, most recently
from
d841ca5
to
21561a7
Compare
fruffy
reviewed
Jul 11, 2024
zzmic
force-pushed
the
compilation-test-support
branch
3 times, most recently
from
3b29458
to
1423109
Compare
fruffy
reviewed
Jul 15, 2024
fruffy
reviewed
Jul 15, 2024
fruffy
reviewed
Jul 15, 2024
zzmic
force-pushed
the
compilation-test-support
branch
from
257c5aa
to
889db85
Compare
fruffy
reviewed
Jul 17, 2024
fruffy
reviewed
Jul 18, 2024
zzmic
force-pushed
the
compilation-test-support
branch
2 times, most recently
from
0d4fbea
to
f778c51
Compare
fruffy
reviewed
Jul 24, 2024
zzmic
force-pushed
the
compilation-test-support
branch
from
ed870d1
to
dae791c
Compare
Signed-off-by: zzmic <100326374 [email protected]>
…programs with different seeds (to inspect the behavior of the generation and compilation process in a finer/smaller granularity) Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…ion-test.sh back to the commit d34f60e, and switch the order of core and generic in backends/p4tools/modules/smith/targets/generic/test/P4Tests.cmake Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…n generating the parameter list for the BMv2 portion of the fuzzer Signed-off-by: zzmic <100326374 [email protected]>
…eName Signed-off-by: zzmic <100326374 [email protected]>
avoid dumping too many generated files after the debugging process Signed-off-by: zzmic <100326374 [email protected]>
…core, preliminarily override the virtual method in the BMv2 backend (still hasn't worked yet) 2. Get rid of and expand the function signature of Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…sts.cmake file instead of the bash script Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…r the dpdk taget Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…l::CompilerBug'` Signed-off-by: zzmic <100326374 [email protected]>
Make further attempts to resolve type resolving Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
…t and return statements Signed-off-by: zzmic <100326374 [email protected]>
zzmic
force-pushed
the
compilation-test-support
branch
from
dae791c
to
e7a47c0
Compare
fruffy
requested changes
Jul 25, 2024
| @@ -20,7 20,7 @@ struct Requirements { | |||
| bool no_methodcalls{false}; | |||
| bool not_zero{false}; | |||
| bool not_negative{false}; | |||
| bool byte_align_headers{false}; | |||
| bool byte_align_headers{true}; | |||
There was a problem hiding this comment.
This should be target-specific.
Use P4Scope::req.byte_align_headers = false;
| @@ -188,6 188,10 @@ IR::Statement *StatementGenerator::genAssignmentStatement() { | |||
| removeLval(left, bitType); | |||
| } | |||
| right = target().expressionGenerator().genExpression(bitType); | |||
| if (left->toString().find("said")) { | |||
fruffy
reviewed
Jul 25, 2024
|
|
||
| # List of known bugs. | ||
| KNOWN_BUGS=( | ||
| "h.eth_hdr.src_addr \* 36646024123162; not implemented" |
There was a problem hiding this comment.
These error patterns are now too specific. Try to catch the most specific, generic error message. For example. "Div or Mux not implemented"
…` back to `IR::ListExpression`
zzmic
force-pushed
the
compilation-test-support
branch
from
1075a03
to
d8d0fde
Compare
…`IR::Type_Declaration`
…` back to `IR::ListExpression`
Signed-off-by: zzmic <100326374 [email protected]>
…b.com> I, zzmic <100326374 [email protected]>, hereby add my Signed-off-by to this commit: d8d0fde I, zzmic <100326374 [email protected]>, hereby add my Signed-off-by to this commit: 3e3b306 I, zzmic <100326374 [email protected]>, hereby add my Signed-off-by to this commit: 0df77ab Signed-off-by: zzmic <100326374 [email protected]>
…ments than the default `genBitType` Signed-off-by: zzmic <100326374 [email protected]>
Signed-off-by: zzmic <100326374 [email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that aims to re-enable
$COMPILER_BIN $TEST_DIR/out.p4and test whether there is any generation or compilation error occurred while executing backends/p4tools/modules/smith/scripts/compilation-test.sh.