Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect loading of file when using the console from a sibling… #26301

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Fixes incorrect loading of file when using the console from a sibling… #26301

merged 1 commit into from
Oct 7, 2016

Conversation

phisch
Copy link
Contributor

@phisch phisch commented Oct 7, 2016

Description

Using the console component from an OC sibling installation will load the incorrect base lib since the path will be relative to the working directory.

Motivation and Context

How Has This Been Tested?

Install 2 instances of OC in a directory structure like:

/var/www/oc-1
/var/www/oc-2

then

cd /var/www/oc-1
../oc-2/occ config:system:get apps_paths

This will output apps_paths from oc-1, even if the oc-2 console was used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mention-bot
Copy link

@PhilippSchaffrath, thanks for your PR! By analyzing the history of the files in this pull request, we identified @carlaschroder, @eMerzh and @butonic to be potential reviewers.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Oct 7, 2016
@LukasReschke
Copy link
Member

This does look familiar somehow… If I only knew why…

@DeepDiver1975
Copy link
Member

This does look familiar somehow… If I only knew why…

I know that feeling .... every single day ... 🙈

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 36dd273 into master Oct 7, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-loading-incorrect-base branch October 7, 2016 14:52
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@phisch @CLAassistant @mention-bot @LukasReschke @DeepDiver1975