Support hot reloading when .css or any other imported file changes #13665
114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit 25b4912 has 9 failures in test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 x64test/cli/watch/watch.test.ts - timeout on 🪟 x64test/cli/watch/watch.test.ts - timeout on 🪟 x64-baselinetest/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baselinetest/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baselinetest/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baselinetest/cli/hot/hot.test.ts - 2 failing on 🪟 x64test/cli/hot/hot.test.ts - 2 failing on 🪟 x64-baselinetest/js/node/process/process.test.js - 2 failing on 🐧 22.04 x64-baselinetest/js/node/process/process.test.js - 2 failing on 🐧 22.04 x64test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64-baseline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support hot reloading when .css or any other imported file changes
To make a file eligible for hot reloading, import the file
Previously, we only supported hot reloading known files like .js, .ts. This makes it work for arbitrary non-virtual files.
Fixes #13652
How did you verify your code works?
There is a test