Return expected data when using Promises with crypto.generateKeyPair #13600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It enables the use of
util.promisify
withcrypto.generateKeyPair
by properly returning the expected data. Previously, we'd only ever handle the first argument of the callback, hence why the public key would always get returned on its own.There are a couple other functions that could use the same work in other parts of the node library, but that can be left for follow-up work.
How did you verify your code works?
bun-debug test test-file-name.test
)Fixes #9469.