New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the panic message better when this assertion failure happens #13579

Merged

Jarred-Sumner merged 1 commit into main from jarred/better-panic-msg

Aug 29, 2024

Collaborator

Jarred-Sumner commented Aug 28, 2024

What does this PR do?

Make the panic message better when this assertion failure happens

How did you verify your code works?

It compiled


Make the panic message better when this assertion failure happens

eea96aa

robobun commented Aug 28, 2024 •

edited

Loading

❌ @Jarred-Sumner, your commit eea96aa has 10 failures in #2420:

test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline

test/cli/watch/watch.test.ts - timeout on 🪟 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64

test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64-baseline

test/cli/hot/hot.test.ts - 3 failing on 🪟 x64-baseline

test/cli/hot/hot.test.ts - 2 failing on 🪟 x64

test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64

test/bundler/bun-build-api.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 13 aarch64

test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 14 aarch64

test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 13 x64

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64

Jarred-Sumner merged commit 743f40b into main

45 checks passed

Jarred-Sumner deleted the jarred/better-panic-msg branch

August 29, 2024 02:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment