Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the V8_UNIMPLEMENTED error include the function name #13559

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Make the V8_UNIMPLEMENTED error include the function name #13559

merged 4 commits into from
Aug 31, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Make the V8_UNIMPLEMENTED error include the function name

How did you verify your code works?

Didn't

@robobun
Copy link

robobun commented Aug 27, 2024 •
edited

❌ @190n, your commit 80ccfbc has 11 failures in #2587:

  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline
  • test/integration/mysql2/mysql2.test.ts - 2 failing on 🐧 20.04 x64
  • test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64
  • test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/hot.test.ts - 2 failing on 🪟 x64
  • test/cli/hot/hot.test.ts - 3 failing on 🪟 x64-baseline
  • test/cli/install/bun-upgrade.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64
  • test/cli/install/registry/bun-install-registry.test.ts - 2 failing on 🍎 14 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 13 aarch64
    		•

    190n
    190n requested changes Aug 28, 2024
    View reviewed changes
    Copy link
    Contributor

    @190n 190n left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    current version doesn't compile

    src/bun.js/bindings/v8/v8.h Outdated Show resolved Hide resolved
    @Jarred-Sumner Jarred-Sumner merged commit 6555248 into main Aug 31, 2024
    45 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the jarred/prettier-unimplemented-error branch August 31, 2024 01:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @190n 190n 190n approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    3 participants
    @Jarred-Sumner @robobun @190n