bug symfony#490 Fix make:functional-test for Symfony 5 (fabpot)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fix make:functional-test for Symfony 5

As of Symfony 5, the Client class has been renamed and does not exist anymore.

Commits
-------

e52c8c4 Fix make:functional-test for Symfony 5

minor symfony#484 Removed Panther dependency from the functional test…

… maker (javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Removed Panther dependency from the functional test maker

This fixes symfony#483.

We'll re-add Panther dependency when/if we create a maker for e2e tests.

Commits
-------

62e62d5 Removed Panther dependency from the functional test maker

bug symfony#486 Changed placeholder to real label (ThomasLandauer)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Changed placeholder to real label

Although common, placing the label into the placeholder is bad practice and reduces usability and accessibility. If people wanna do it this way, they still can; but it shouldn't be suggested :-)

If you merge it, I'll update the docs at https://symfony.com/doc/current/security/form_login_setup.html#generating-the-login-form too.

Commits
-------

fd5a6d5 Changed placeholder to real label

bug symfony#480 Allow Symfony 5   many cleanups (nicolas-grekas)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Allow Symfony 5   many cleanups

Note that having php-cs-fixer in the deps blocks installing Symfony 5 (did I already mention it's a bad practice to add tools as deps? ;) )
But locally when I remove php-cs-fixer (and patch the code to use my local version), all is green, with SF5 deps.

Commits
-------

2cf9460 Allow Symfony 5   many cleanups

bug symfony#469 Fixed make:auth when using a custom repository method…

… as UserProvider (romaricdrigon)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixed make:auth when using a custom repository method as UserProvider

Hello,

It is possible in vanilla Symfony to change how the User is retrieved by the `entity` user provider, so you use your own repository - [https://symfony.com/doc/current/security/user_provider.html#using-a-custom-query-to-load-the-user](https://symfony.com/doc/current/security/user_provider.html#using-a-custom-query-to-load-the-user). Then you remove `providers.xxxx.entity.property` key.

Unfortunately, it causes `make:auth` command to crash:
![image](https://user-images.githubusercontent.com/919405/64244498-6fde3680-cf09-11e9-8edb-79db50b3936e.png)

This PR patches `InteractiveSecurityHelper`, so it checks `property` key exists before reading from it. No BC break.
I added a test for that very specific use case.

Commits
-------

7014d93 Fixed make:auth when using a custom repository method as UserProvider

bumping 1.13 changelog

minor symfony#441 Fix tests (weaverryan)

This PR was squashed before being merged into the 1.0-dev branch (closes symfony#441).

Discussion
----------

Fix tests

Tests are a bit broken after some upstream changes and some tweaks to the matrix. I'd like to stabilize them before 1.12.

Commits
-------

f4561c0 removing allow_failures and not testing lowest for now
6a23426 playing with windows commands
5ac989b Fixing cs
0be971b removing global flex install

bug symfony#376 [make:validator] Custom constraints should ignore nul…

…l and empty values (voronkovich)

This PR was squashed before being merged into the 1.0-dev branch (closes symfony#376).

Discussion
----------

[make:validator] Custom constraints should ignore null and empty values

See https://symfony.com/doc/current/validation/custom_constraint.html#creating-the-validator-itself

Commits
-------

c959791 [make:validator] Custom constraints should ignore null and empty values

bug symfony#370 [make:validator] Prevent an error in PHPStorm (dungla…

…s, weaverryan)

This PR was merged into the 1.0-dev branch.

Discussion
----------

[make:validator] Prevent an error in PHPStorm

The currently generated DocBlock prevent auto-completion to work properly, and triggers a warning. This patch fixes it.

Commits
-------

1d3bb7c adding slash so the class name is absolute
13f555b move to template
5fc99a5 [make:validator] Prevent an error in PHPStorm

Fixing bugs in test that I missed in the PR

At least for using Maker, your code won't work immediately if you have
required constructor args. So, to get a successful "we ran make and then
we can immeidately use the code in the test", those were removed