Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from doubles to floats broke rho update #574

Open
jamespinkerton opened this issue Aug 1, 2023 · 1 comment
Open

Moving from doubles to floats broke rho update #574

jamespinkerton opened this issue Aug 1, 2023 · 1 comment

Comments

@jamespinkerton
Copy link

Hi. I tried solving series of embedded problems I'm used to solving successfully with doubles. I set OSQPFloat to be single-precision and it failed to update rho. When I turn off rho updates, the problem solves.

Any idea why this is happening?

Thanks so much

@imciner2
Copy link
Member

imciner2 commented Aug 2, 2023

Can you clarify what you mean by failing to update rho? Do you mean it has failed to actually solve the problem when adaptive rho is enabled, or that there is a different error returned?

Moving from doubles to floats will change how the solver converges and behaves, especially if the convergence criteria is left the same, since ADMM can be more susceptible to the reduced precision effects and so it can be more difficult to reach the higher tolerance.

Any further debugging would probably require code/problem data so that we can look at what the solver is doing during the solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants