-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Constants? #14
Comments
It might be good to include all constants recommended as best practices in Dickson, Sabine and Christian (2007), even if there are more recent formulations. I see two differences:
|
Good thoughts @tompc35. Briefly:
|
Hi. One question, since I'm not super familiar with the backgrounds of this program and the respective algorithms but using it for my master thesis: |
Hi @markusritschel, thanks for getting in touch! The short answer to your specific question is 'no'. It's not currently possible to select alternative parameter sets as an option. I've only incorporated the ones listed above, as they're listed in the 'Best Practices' guide and seem to provide the best match to GLODAP bottle data (see project README). The longer answer is that this is possible by manually specifying constants... although this is a little clunky at present. You just need to pass a full set of Ks to the 'Csys' function call. For example:
This would become a bit more of a nuisance if you were calculating a lot of samples with varying T/S/P, as calculation of conditional Ks would not be handled automatically - i.e. you'd have to adjust them for T/S/P yourself. This would become particularly tricky when dealing with different input/output conditions. It wouldn't be too much of a nuisance to incorporate other Ks... although the motivation for me to do it is low, as I work predominantly in seawater where the Ks I've already got work well! If I get enough interest in it, I'll look into it in the New Year. |
Would other constants be useful?
At present, there are no options for different constants in cbsyst. Do people want/need choices?
Request constants in the comments below. If they get traction (i.e. lots of 1's), we'll implement them.
At present:
Constants as a function of Temperature and Salinity:
Pressure Corrections
All pressure correction parameters from Millero (2007), with modifications:
Conserved Seawater Compositions:
As a function of salinity:
Lee et al (2010)Uppstrom, (1974) IF no value provided. You can specify BT at S=35, and it scales with salinity.The text was updated successfully, but these errors were encountered: