-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to aws sdk go v2 #1070
base: master
Are you sure you want to change the base?
Migrate to aws sdk go v2 #1070
Conversation
Hey @johannesvietze, thank you for working on this! |
I'm on vacation for two weeks. If there's no hurry, I can have a look after. Otherwise, feel free to take over. |
Hi @orlangure, I found some time to fix the test. Could you please check the 4 open TODOs (they are all related to the same thing...)? The aws-sdk-go-v2 migration added a leading slash to some prefixes... |
Hey @johannesvietze, I see that TODO comments are only in the test code, so it shouldn't affect the users. The users are free to use whichever aws sdk version they like. The changes behind these comments look good to me. |
sounds good, I have removed the TODOs |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1070 /- ##
==========================================
- Coverage 85.87% 77.08% -8.79%
==========================================
Files 50 55 5
Lines 2350 2623 273
==========================================
Hits 2018 2022 4
- Misses 173 443 270
Partials 159 158 -1 ☔ View full report in Codecov by Sentry. |
hey @orlangure could you have a look? not sure why the linter fails... |
fixes #1030