MDN Web Docs
Do we need {{EmbedGHLiveSample}} macro now that we have playable {{EmbedLiveSample}} macro?
#687
Replies: 2 comments 1 reply
-
|
Hey @OnkarRuikar I'm pretty much on board with this, however I think we'll find some examples that are going to be hard to migrate to The long term goal would be to find a way to do this, but initially point 3. is a big yes - if we could move anything that can be moved to |
Beta Was this translation helpful? Give feedback.
-
|
Although they have drawbacks, there are various reasons people have opted to use EmbedGHLiveSample over the years.
I agree that EmbedLiveSample should be the default tool people reach for in most cases, but at the moment, there are a few reasons people might want to use EmbedGHLiveSample. So it seems premature to deprecate it.
Are there lots of cases where people add new GHLiveSamples that could easily have been LiveSamples? I mean, is this a real problem?
If there are examples that would fit better as live samples, moving them seems fine. But it's a project to assess which ones they are. |
Beta Was this translation helpful? Give feedback.
-
Technically both the macro outputs are rendered in
Yes EmbedGHLiveSample does avoid some duplication.
We do have
If we strip playground infra code from EmbedGHLiveSamples then most of the samples will become super short. For example we repeat code in
We are not getting rid of
While editing learn pages people, looking at reset of the page, mostly opt for GHLiveSamples. I am asking to change the practice like I've done here: mdn/content#33998
We don't necessarily have to asses everything before hand. We could simply ask people if it works with |
Beta Was this translation helpful? Give feedback.
-
The {{EmbedGHLiveSample}} macro embeds interactive demos from
https://mdn.github.iowebsite using<iframe>tag. E.g. Playing with box model demo.Now the other macro {{EmbedLiveSample}} has been made playable it is way better than the
EmbedGHLiveSample. E.g. Box shadow example.The
EmbedGHLiveSamplerequires to create example in other repos. So it is hard to implement and maintain such content. On the other hand theEmbedLiveSamplemacro is more versatile and more prevalent.My questions are:
EmbedGHLiveSamplemacro in yari?EmbedGHLiveSamplemacro?EmbedLiveSample? This will help in other aspect that we've been eyeing on merging examples repos inmdn/contentrepo since long time.Beta Was this translation helpful? Give feedback.
All reactions