Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Music Discs Require two discs to play unless in creative #1450

Closed
4 tasks done
jtwebhomer opened this issue Jul 6, 2024 · 4 comments
Closed
4 tasks done

[BUG] Music Discs Require two discs to play unless in creative #1450

jtwebhomer opened this issue Jul 6, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jtwebhomer
Copy link

I have checked...

  • I am using the latest version of Oraxen
  • I am using the latest version of any dependencies
  • I am using ProtocolLib 5.0
  • I have checked if any similar bug reports exist

Description

Music Discs Require two discs in inventory to play properly unless in creative....they will sometimes play with just one but when they play they will pop out of the jukebox right away and it will play as a sound that sometimes needs to be stopped through /stopsound record.......sometimes popping the same disc into the jukebox will actually stop it from playing, but if you have two discs it will work as it should

Steps to reproduce

Add this to a new .yml file in items folder
`treasure:
displayname: <#55FFFF>Music Disc
material: PAPER
lore:

  • "<#AAAAAA>astral - Treasures"
    Mechanics:
    music_disc:
    song: minecraft:treasure.mysong
    Pack:
    generate_model: true
    parent_model: "item/generated"
    textures:
    • lyra/music_disc_treasure
      custom_model_data: 1548`

add this section to the appropriate section to sounds.yml
treasure.mysong: category: record sound: treasure.ogg

add treasure.ogg to pack/sounds

restart server or reload plugin (in this case i restarted server completly)

rejoin

do /o give yournamehere treasure
make sure your in survival
put the disc in a jukebox (bug will only happen if you have one of that exact disc)

Plugin Version

image

ProtocolLib Version

image

Server Software & Version

image

How breaking is the bug?

Minor Bug - Plugin completely functional, but features have non-working aspects

@jtwebhomer jtwebhomer added the bug Something isn't working label Jul 6, 2024
@jtwebhomer
Copy link
Author

update, it might be a bug with protocol lib but i will leave it here, i downgraded to protocollib SNAPSHOT 721 from 723 and it no longer is buggy

@jtwebhomer
Copy link
Author

so it plays with the disc inside but it doesnt follow proximity like vanilla discs......doesnt matter how far i go i can still hear the music

@jtwebhomer
Copy link
Author

not sure if players who are far from jukebox when it starts if they can hear music need to wait for a player to get on to ask

@Boy0000
Copy link
Member

Boy0000 commented Jul 21, 2024

as your console probably tells you, for 1.21 you should use the new jukebow_playable property, not this mechanic

@Boy0000 Boy0000 closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants