Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48470] Remove extra version component. #7366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

graalvmbot
Copy link
Collaborator

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 7, 2023
@zakkak
Copy link
Collaborator

zakkak commented Sep 7, 2023

@gilles-duboscq how do you plan to handle releases that might need to be built on exactly the same JDK as a previous GraalVM release moving forward? Are such releases no longer an option?

@gilles-duboscq
Copy link
Member

I'm thinking of 2 options that would probably be less confusion than this extra .X in there:

  • use the fifth digit of the jdk version (e.g., 21.0.0.0.1) either in the labsjdk itself (meaning it needs to be re-built) or just in the vendor version (which can be updated just via jlink).
  • Add something in java.vm.version and/or java.runtime.version (that does mean re-building a labsjdk)
    What do you think?

@zakkak
Copy link
Collaborator

zakkak commented Sep 7, 2023

What do you think?

I personally prefer the vendor version approach, but there is a discussion in quarkusio/quarkus#34161 about using the release file to get the version, and I am afraid the vendor version is not reflected there. Anything requiring rebuilding labsjdk, while nothing changes in it, doesn't feel right to me but at the same time it shouldn't really affect us (either on the Mandrel side or the Quarkus side).

cc @jerboaa @Karm

@jerboaa
Copy link
Collaborator

jerboaa commented Sep 7, 2023

Personally: That's what the vendor version is for in OpenJDK.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 2, 2023

What is the plan for maven artifacts? Is the plan to keep the old version scheme for them? I.e. how does a graal-js dependency look like in a pom going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants