Add capability to reload Source objects. #23
Conversation
|
What's the use case? |
|
Seems a bit strange to me. Wouldn't you rather want an uncached URL/File Source? You could then simply create a new one when you need it up-to-date. |
|
There was d929423 and I got a feeling that Source is supposed to be immutable. That seems to be OK in this proposal, but the general motivation for the change is unclear. |
|
I need the change in R to auto reload source files on changes. There is no way to reload a source from with a given URL atm. Its always returning the same Source object which caches the code as field and never reloads its contents. We would not need this change if URL source would not cache their instances globally. I am happy to remove the cache instead. @mlvdv I think you introduced the URL source cache. Do you remember its rationale? |
|
No, I'm not sure what the conversation was about that. The original Source object wasn't much more than a collection of use cases in the different languages, since every language handled sources differently. |
|
I think we should remove the current (static!) cache from Source. Perhaps we could split it out into a separate API that builds on top of Source that languages can optionally use if they need caching (e.g. "SourceCache"), perhaps tied to a PolyglotEngine instance? |
|
OK. I prefer to remove the cache rather than trying to introduce an API for reload. |
|
How such change affects Source.equals then? Right now it assumes that if Source comes from the same File/URL it is the same one. That will no longer be true - the equals will have to be modified to really compare the content. |
|
I don't think Source#equals should compare the code for File sources or URL sources as they are mutable. For literal sources it might be a good idea to compare the sources itself on equals. |
|
Closing. Will open another one where I remove the caching capability. |
|
So what should Source#equals compare? Identity? |
…truffle:prepare-0.13 to master Ready to release version of truffle-0.13 * commit 'a4ac0aa8e852074b133f4d40f67c9c2a51a725da': Load the ContextStoreProfileTest test with the same classloader as the ContextStore classes. root is mutable instance variable - just checking against null doesn't provide much safety - using local copy Documenting SL JAR split Split TRUFFLE_SL_TEST out of TRUFFLE_SL Add maven-deploy dry-run to the gate Removing assignSourceSection and clearSourceSection from the API signature files Adding missing Javadoc with @SInCE tag Better formatting of the release 0.13 notes Adjusting the signature files to the state as of version 0.13 Documenting what is new in version 0.13 Remove deprecated source section API from Node.
I needed the capability to reload sources. Especially with url caching this can be hacky. So I introduced a new method reload in Source that keeps the original source unmodified but reloads the code from the URL or File.