Focus withDefault feature, removed Eq constraint on withDefault everywhere #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,6 48,9 @@ private[focus] trait ParserLoop { | |||
| case KeywordAs(Right(remainingCode, action)) => loop(remainingCode, action :: listSoFar) | |||
| case KeywordAs(Left(error)) => Left(error) | |||
|
|
|||
| case KeywordWithDefault(Right(remainingCode, action)) => loop(remainingCode, action :: listSoFar) | |||
There was a problem hiding this comment.
I wonder if there is a way to capture this pattern of KeyWord(Left(e)) => e
There was a problem hiding this comment.
No doubt, there's a few drops of juice left to squeeze out. It's not a priority for me at this point, it's completely sterile as far as unwanted code growth is concerned, and squeezing harder risks overfitting.
julien-truffaut
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus
withDefaultfeature, resolving #1031Of note:
Eqconstraint fromwithDefaultinstd.optionand in all the optics, because it adds an intolerable usability hurdle to Focus, and provides little value for thewithDefaultusecase on its ownFocusKeywordmatcher inParserBaseto accomodate value parameters with no typeclass