Fix#20125: Correct Flake (Error Using Google Docs Viewer with Puppeteer) in Logged-In User Acceptance Tests. #20210
Conversation
|
Assigning @StephenYu2018 for the first pass review of this PR. Thanks! |
rahat2134
changed the title
| * URL, then these errors can arise. So, we ignore these errors. | ||
| * Using regex because each time the exploration ID will be different. | ||
| */ | ||
| // After deleting the exploration if we want to access the exploration with the |
There was a problem hiding this comment.
Add a comma after "exploration".
|
|
||
| const DEFAULT_SPEC_TIMEOUT_MSECS = testConstants.DEFAULT_SPEC_TIMEOUT_MSECS; | ||
|
|
||
| // Exclude the error related to Google Docs Viewer since it's from an external service | ||
| // and cannot be controlled. |
There was a problem hiding this comment.
controlled --> controlled by us
|
|
||
| const DEFAULT_SPEC_TIMEOUT_MSECS = testConstants.DEFAULT_SPEC_TIMEOUT_MSECS; | ||
|
|
||
| // Exclude the error related to Google Docs Viewer since it's from an external service | ||
| // and cannot be controlled. | ||
| // https://stackoverflow.com/questions/50909239/how-to-use-google-docs-viewer-with-puppeteer |
There was a problem hiding this comment.
Use the shortlink: https://stackoverflow.com/q/50909239
|
@rahat2134 Please update the title of the PR to mention the name of the flake (synopsis of error message) and that it occurs in the "logged-in user acceptance tests". The current title is quite unclear. Thanks. |
|
Assigning @StephenYu2018 for code owner reviews. Thanks! |
rahat2134
changed the title
|
@rahat2134 "error message synopsis" means a summary of the error message, not the literal text "error message synopsis". |
rahat2134
changed the title
|
@seanlip @rahat2134 FYI just wanted to note since I got notified on my repository that a google api key was detected, should use a regex here instead of the raw key since it can change. WDYT? |
|
Oh, I didn't realize the key can change ... I think a regex is a good idea, thanks @jnvtnguyen! (I'm also kind of confused where this key is being generated from, tbh, since AFAIK no one is logged in during this test.) @rahat2134 can you make the change please? |
|
Oh maybe it doesn't change since all of the keys are the same in the occurences but generally things like API keys should not be explicitly set in code IG. |
|
I initially considered using regex, but then I noticed that the error was consistent each time. |
Overview
When using Puppeteer to preview documents via Google Docs Viewer in Node.js, the browser throws an error. Despite the URL working well in a browser environment, attempting to access it through Puppeteer results in an error.
Set that error to ignore because it was from external factors and breaking the tests.
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
PR Pointers