Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update authors since 036a435 #20158

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Update authors since 036a435 #20158

merged 4 commits into from
Apr 16, 2024

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Apr 14, 2024 •
edited

Overview

  1. This PR fixes or fixes part of #N/A.
  2. This PR does the following: Routine update of AUTHORS/CONTRIBUTORS

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code. -- N/A, this is a routine fix
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

No proof of changes needed because this PR is autogenerated.

@seanlip seanlip requested review from a team as code owners April 14, 2024 17:53
@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 14, 2024

Assigning @vojtechjelinek for the first pass review of this PR. Thanks!

@seanlip
Copy link
Member Author

seanlip commented Apr 14, 2024

@vojtechjelinek @Nik-09 PTAL. Thanks!

@seanlip seanlip enabled auto-merge April 14, 2024 18:35
@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 15, 2024

Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks!

Nik-09
Nik-09 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Nik-09 Nik-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you.

@Nik-09 Nik-09 removed their assignment Apr 15, 2024
@seanlip seanlip removed their assignment Apr 15, 2024
vojtechjelinek
vojtechjelinek approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanlip seanlip added this pull request to the merge queue Apr 16, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 16, 2024

Unassigning @vojtechjelinek since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Apr 16, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 16, 2024

Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

Merged via the queue into develop with commit 231b09b Apr 16, 2024
77 checks passed
@seanlip seanlip deleted the update-authors-since-036a435 branch April 16, 2024 14:09
@Akhilesh-max Akhilesh-max mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@Nik-09 Nik-09 Nik-09 approved these changes

Assignees

@seanlip seanlip

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanlip @vojtechjelinek @Nik-09