Updates or creates exploration voice artists link model during exploration update #20075
Conversation
…into voice_artist_names_job
…rtist_names_job
| @@ -2079,6 2080,9 @@ def compute_models_to_put_when_saving_new_exp_version( | |||
| ) | |||
| ) | |||
|
|
|||
| voiceover_services.update_exploration_voice_artist_link_model( | |||
There was a problem hiding this comment.
The method updates the exploration voice artists link model data for an exploration after the MR jobs have been triggered. This ensures the model always be consistent with the latest exploration data even after successful run of MR job.
| representing the latest version. | ||
| """ | ||
|
|
||
| if not feature_flag_services.is_feature_flag_enabled( |
There was a problem hiding this comment.
This feature flag needs to be truned on after the job has successfully ran in prod servers.
Adding @seanlip for visibility. (I am updating the instruction doc for the beam job regarding this feature flag)
| return | ||
|
|
||
| is_voiceover_changes_made: bool = False | ||
| for change in change_list: |
There was a problem hiding this comment.
Checks if any voiceover related changes are made or not.
|
Hi @vojtechjelinek, @BenHenning PTAL at this PR once you are free. |
core/domain/voiceover_services.py
Outdated
|
|
||
| Args: | ||
| user_id: str. The committer ID for the given change list. | ||
| change_list: list(ExplorationChange). A list of exploration chnage |
There was a problem hiding this comment.
| change_list: list(ExplorationChange). A list of exploration chnage | |
| change_list: list(ExplorationChange). A list of exploration change |
There was a problem hiding this comment.
Hi @vojtechjelinek and @BenHenning a frindly ping to please review the PR once you are free.
Thank you
|
Unassigning @vojtechjelinek since they have already approved the PR. |
There was a problem hiding this comment.
Thanks @Nik-09! Apologies for the delay--just had one comment otherwise the PR LGTM.
There was a problem hiding this comment.
Thank you @BenHenning for the suggestion, I have updated the code. PTAL once you are free.
|
Hi @Nik-09, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
The method updates the voice artist link model whenever voiceover-related changes are made in an exploration.
Essential Checklist
Proof that changes are correct
The video shows after adding voiceovers in Bangla language the ExplorationVoiceArtistsLinkModel automatically got updated, without explicitly running the MR job.
update_exp_voice_artist_link.mp4
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers