Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use helm charts to install yurt-manager and yurthub components in a local kind cluster #2074

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

  • improve make local-up-openyurt command:

    instead of using yaml constants, use helm charts to install yurt-manager and yurthub components in a local kind cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch force-pushed the improve-local-up-openyurt branch from e0ffb28 to 3794138 Compare June 7, 2024 01:54
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.03%. Comparing base (3713163) to head (1eed354).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2074       /-   ##
==========================================
- Coverage   56.09%   56.03%   -0.07%     
==========================================
  Files         186      186              
  Lines       18092    18092              
==========================================
- Hits        10149    10137      -12     
- Misses       6910     6921       11     
- Partials     1033     1034        1     
Flag Coverage Δ
unittests 56.03% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch force-pushed the improve-local-up-openyurt branch 5 times, most recently from 2ef7050 to 785718a Compare June 7, 2024 08:53
…al kind cluster instead of using yaml constants.
@rambohe-ch rambohe-ch force-pushed the improve-local-up-openyurt branch from 785718a to 1eed354 Compare June 7, 2024 09:30
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@YTGhost YTGhost merged commit d82b780 into openyurtio:master Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants