Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gateway can forward traffic from extra source cidrs #1993

Merged

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Mar 26, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature
/sig network

What this PR does / why we need it:

This PR allows traffic from non-clustered nodes to be forwarded via raven to hosts or containers in other regions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 52.99%. Comparing base (183e739) to head (a03feb9).

Files Patch % Lines
...r/raven/gatewaypickup/gateway_pickup_controller.go 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1993       /-   ##
==========================================
- Coverage   53.03%   52.99%   -0.04%     
==========================================
  Files         176      176              
  Lines       20929    20944       15     
==========================================
  Hits        11099    11100        1     
- Misses       8882     8895       13     
- Partials      948      949        1     
Flag Coverage Δ
unittests 52.99% <73.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@River-sh Thanks for making pull request, please add unit tests for your pull request.

@River-sh River-sh force-pushed the features/raven_allowed_extra_cidr branch from f4c3dca to a03feb9 Compare March 26, 2024 06:49
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Mar 26, 2024
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 9769ab2 into openyurtio:master Mar 26, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants