Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodebucket crd and controller #1874

Merged
merged 1 commit into from
Jan 18, 2024
Merged

add nodebucket crd and controller #1874

merged 1 commit into from
Jan 18, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

  1. add NodeBucket CRD
  2. add nodebucket controller for managing NodeBucket resource.
  3. one NodeBucket can store 100 nodes info by default. and parameter --max-nodes-per-bucket can be used for configuring the number of nodes in NodeBucket.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@rambohe-ch rambohe-ch force-pushed the add-nodebucket-crd-controller branch 2 times, most recently from 4c0bb68 to 120b1e4 Compare December 27, 2023 11:16
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited
Loading

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (81d21b7) 52.16% compared to head (ff928df) 52.25%.

Files Patch % Lines
...ger/controller/nodebucket/nodebucket_controller.go 59.18% 92 Missing and 8 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1874       /-   ##
==========================================
  Coverage   52.16%   52.25%    0.09%     
==========================================
  Files         172      173        1     
  Lines       20874    21119      245     
==========================================
  Hits        10888    11035      147     
- Misses       9018     9109       91     
- Partials      968      975        7
Flag Coverage Δ
unittests 52.25% <59.18%> ( 0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch force-pushed the add-nodebucket-crd-controller branch from 120b1e4 to 245d612 Compare December 28, 2023 01:48
@rambohe-ch
Copy link
Member Author

@JameKeal PTAL

@rambohe-ch rambohe-ch requested a review from JameKeal January 12, 2024 09:11
@JameKeal
Copy link
Member

@JameKeal PTAL

I review the code, the major logic has no problems.

@JameKeal
Copy link
Member

please resolve the conflict files.

@rambohe-ch rambohe-ch force-pushed the add-nodebucket-crd-controller branch from 245d612 to ff928df Compare January 17, 2024 02:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@JameKeal JameKeal merged commit 3dd6c5c into openyurtio:master Jan 18, 2024
13 checks passed
@rambohe-ch rambohe-ch mentioned this pull request Jan 23, 2024
Merged
@open-digger-bot open-digger-bot bot mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JameKeal JameKeal JameKeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rambohe-ch @JameKeal