Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Enhancement about tweaks of yurtappset #1970

Closed
vie-serendipity opened this issue Mar 6, 2024 · 4 comments
Closed

[feature request] Enhancement about tweaks of yurtappset #1970

vie-serendipity opened this issue Mar 6, 2024 · 4 comments
Labels

Comments

@vie-serendipity
Copy link
Member

What would you like to be added:
Add {{nodepool}} to replace the specified nodepool, users can batch inject configmap and secret that match the naming rules.

Why is this needed:
There may be different configmaps for different nodepools, and the user may need to write tweaks one by one. After joining {{nodepool}}, the user can bulk write by regularly naming the configmap and secret, like configmap-xxx (xxx represents the detailed name of nodepool).

others
/kind feature

@vie-serendipity vie-serendipity added the kind/feature kind/feature label Mar 6, 2024
@rambohe-ch
Copy link
Member

@vie-serendipity It's a good idea to use {{nodepool}} to match multiple nodepools, as it allows users to easily perform batch configurations at the nodepool level.

I think we should make the definition more clearly, so how about use {{nodepool-name}} to replace {{nodepool}}?

@vie-serendipity
Copy link
Member Author

@rambohe-ch Good idea.

@vie-serendipity
Copy link
Member Author

/assign @vie-serendipity

Copy link

stale bot commented Jun 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants