Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Move in NodeLifeCycle to yurt-manager #1713

Closed
JameKeal opened this issue Sep 20, 2023 · 4 comments
Closed

[feature request]Move in NodeLifeCycle to yurt-manager #1713

JameKeal opened this issue Sep 20, 2023 · 4 comments
Assignees
Labels
kind/feature kind/feature

Comments

@JameKeal
Copy link
Member

What would you like to be added:
Move in nodelifecycle controller to yurt-manager, and disable it in kube-controller-manager. In the mean time, add some logic on it to process some questions, like pod evict and status updates when node or nodepool is not ready.

Why is this needed:
We use webhook and add some controllers to process question at present, we add pod and node webhook, it may be in trouble when webhook not running, and the cluster will not process pod and node. And use webhook increase calling link time, so we need to replace it with a better way.

others
/kind feature

@JameKeal JameKeal added the kind/feature kind/feature label Sep 20, 2023
@rambohe-ch
Copy link
Member

@JameKeal I agree with your idea to add NodeLifeCycle controller into yurt-manager, and i will take over this work.

@rambohe-ch
Copy link
Member

/assign @rambohe-ch

@rambohe-ch
Copy link
Member

/close

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

3 participants