Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gift card search appears broken #4030

Open
1 task done
odiea opened this issue Jul 22, 2024 · 5 comments
Open
1 task done

[Bug]: Gift card search appears broken #4030

odiea opened this issue Jul 22, 2024 · 5 comments

Comments

@odiea
Copy link
Collaborator

odiea commented Jul 22, 2024

Bug Description?

Enter a gift card as payment in Sales. Card 101 only displays card 1.

Steps to Reproduce?

Enter a gift card as payment in Sales. Card 101 only displays card 1.

Expected Behavior?

Card search should display card 101 not 1.

OpensourcePOS Version

development (unreleased)

Php version

Php 8.4

What browsers are you seeing the problem on?

Chrome

Server Operating System and version

wamp Server

Database Management System and version

mysql

Web Server and version

Wamp Server

System Information Report (optional)

No error log displays. In network search does show it has issues.

Unmodified copy of OpensourcePOS

  • I agree this copy has not been modified
@odiea odiea added the bug label Jul 22, 2024
@jekkos jekkos added this to the 3.4.0 milestone Aug 7, 2024
@objecttothis
Copy link
Member

@odiea I can't replicate this on the development branch I'm working on now. I wonder if this is specific to MySQL 8.4. If it is, then my vote is to just get this release out with MySQL <= 8.3 support and then work on MySQL 8.4 support in a different release. Any chance you can test it in 8.3 or lower to see if the error persists?

@odiea
Copy link
Collaborator Author

odiea commented Aug 26, 2024

Sorry I was testing this in 8.2 or 8.3. Don't know where I got 8.4.

@objecttothis
Copy link
Member

OK, it must have been introduced recently because I just changed to a new branch which has been rebased on the master and I can now replicate it. I'll have to investigate it more after fixing the attributes problems.

@odiea
Copy link
Collaborator Author

odiea commented Aug 26, 2024

In Controller/Giftcards I changes line 61 from Post to Get and it started working better.

public function getSuggest(): void
	{
		$search = $this->request->getGet('term');
		$suggestions = $this->giftcard->get_search_suggestions($search, true);

		echo json_encode($suggestions);
	}

jekkos added a commit that referenced this issue Aug 27, 2024
Switch back to master in docker-compose.yml
@jekkos
Copy link
Member

jekkos commented Aug 27, 2024

Fix is in master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants