Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.7] Include proto swagger in discovery #18309

Merged
merged 1 commit into from
Jan 29, 2018
Merged

[release-3.7] Include proto swagger in discovery #18309

merged 1 commit into from
Jan 29, 2018

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #18105

/assign juanvallejo

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2018
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 26, 2018

needs OSE pick

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 26, 2018

/hold
actually, I'm not certain this path existed in 3.7... can you check?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2018
@juanvallejo
Copy link
Contributor

@liggitt checked against free-stg:

$ oc version
oc v3.7.0 7ed6862-dirty
kubernetes v1.7.6 a08f5eeb62
features: Basic-Auth

Server https://api.free-stg.openshift.com:443
openshift v3.7.23
kubernetes v1.7.6 a08f5eeb62

$ oc get --raw /
{
  "paths": [
    "/api",
    "/api/v1",
...
    "/metrics",
    "/oapi",
    "/oapi/v1",
    "/swagger-2.0.0.json",
    "/swagger-2.0.0.pb-v1",
    "/swagger-2.0.0.pb-v1.gz",
    "/swagger.json",
    "/swaggerapi",
    "/version",
    "/version/openshift"
  ]
}%

@liggitt
Copy link
Contributor

liggitt commented Jan 26, 2018

ok, good, must have just moved in the code in 1.8
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2018
@juanvallejo
Copy link
Contributor

/test gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 284b8b7 into openshift:release-3.7 Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@liggitt liggitt

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @liggitt @openshift-ci-robot @juanvallejo @openshift-bot @openshift-merge-robot