Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 50390: Admit sysctls for other runtime. #17274

Merged
merged 1 commit into from
Nov 14, 2017
Merged

UPSTREAM: 50390: Admit sysctls for other runtime. #17274

merged 1 commit into from
Nov 14, 2017

Conversation

runcom
Copy link
Member

@runcom runcom commented Nov 13, 2017

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Nov 13, 2017
@runcom runcom changed the title UPSTREAM: 50390|drop: Admit sysctls for other runtime. UPSTREAM: 50390: Admit sysctls for other runtime. Nov 13, 2017
@bparees
Copy link
Contributor

bparees commented Nov 13, 2017

/unassign

@mrunalp
Copy link
Member

mrunalp commented Nov 13, 2017

LGTM.

@derekwaynecarr
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2017
@derekwaynecarr derekwaynecarr modified the milestone: 3.8.0 Nov 13, 2017
@derekwaynecarr
Copy link
Member

low risk, and eases ability to try out cri-o

/kind bug
/approve

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, runcom

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrunalp
Copy link
Member

mrunalp commented Nov 14, 2017

/retest

@openshift-ci-robot
Copy link

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update bc05917 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_install bc05917 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16843, 17095, 17267, 17261, 17274).

@openshift-merge-robot openshift-merge-robot merged commit 653c547 into openshift:master Nov 14, 2017
@runcom runcom deleted the cri-o-sysctls branch November 14, 2017 08:40
@liggitt
Copy link
Contributor

liggitt commented Nov 14, 2017

this should not have merged. no kube changes in 3.8 prior to the rebase landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@runcom @bparees @mrunalp @derekwaynecarr @openshift-merge-robot @openshift-bot @openshift-ci-robot @liggitt @soltysh