Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/2020 - Add chat log duration setting #2033

Merged
merged 3 commits into from
Jan 18, 2023
Merged

enhancement/2020 - Add chat log duration setting #2033

merged 3 commits into from
Jan 18, 2023

Conversation

rcobelli
Copy link
Contributor

Resolves #2020

The purpose of this change is to allow users to adjust how long a chat message will remain visible before fading out. Currently messages are shown for 3 seconds (the new default value for the setting) but users can now change the delay to any valid number greater than 0

Note: The link to join slack doesn't work so I can't request access to the repo. Hence why this PR is from a fork

Copy link
Member

@n8rzz n8rzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! I left a few bits of feedback, though most are pretty minor/style tweaks. Please reach out and let me know if you have any questions!

src/assets/scripts/client/constants/eventNames.js Outdated Show resolved Hide resolved
src/assets/scripts/client/ui/UiController.js Outdated Show resolved Hide resolved
src/assets/scripts/client/ui/UiController.js Outdated Show resolved Hide resolved
src/assets/scripts/client/ui/UiController.js Outdated Show resolved Hide resolved
src/assets/scripts/client/ui/UiController.js Show resolved Hide resolved
@rcobelli rcobelli requested a review from n8rzz December 13, 2022 23:49
Copy link
Member

@n8rzz n8rzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you for your contributions! We really appreciate it.

@erikquinn erikquinn added feature Addition of a COMPLETELY NEW feature enhancement Notable improvement or expansion upon an EXISTING feature and removed feature Addition of a COMPLETELY NEW feature labels Jan 18, 2023
rcobelli and others added 3 commits January 18, 2023 13:50
Resolves #2020

The purpose of this change is to allow users to adjust how long
a chat message will remain visible before fading out. Currently
messages are shown for 3 seconds (the new default value for the
setting) but users can now change the delay to any valid number
greater than 0
@erikquinn erikquinn merged commit 06ca903 into openscope:develop Jan 18, 2023
@erikquinn erikquinn added this to the v6.29.0 milestone Jan 18, 2023
@rcobelli rcobelli deleted the enhancement/2020 branch January 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Notable improvement or expansion upon an EXISTING feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to have aircraft repeat last transmission
3 participants