Allow to override build date with SOURCE_DATE_EPOCH #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This patch was done while working on reproducible builds for openSUSE. Signed-off-by: Bernhard M. Wiedemann <[email protected]>
|
We already look for and set |
|
bot:ibm:retest |
|
Interestingly enough, this patch now allows someone to build the PMIx docs and claim copyright into the future years by simply setting an envar - see open-mpi/ompi#11847 which raises that issue. Should there be logic to disallow passing a future date? |
|
Guess we allow this envar to override the build date elsewhere, so might as well be consistent - though I still have no idea how you got the error you report (unless you deliberately set your system clock to some bizarre future time?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override build date with
SOURCE_DATE_EPOCHto make builds reproducible.See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
Without this patch, I got variations in our
openmpi5package:This patch was done while working on reproducible builds for openSUSE.
Signed-off-by: Bernhard M. Wiedemann bwiedemann suse de