New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code for modifying PAM and PAM module conf files #16

Closed

jmbills opened this issue May 9, 2023 · 1 comment

Assignees

Contributor

jmbills commented May 9, 2023

There are two functions: getPamModuleConfValue() and getPamModuleArgValue() that do basically the same thing and share a lot of code.

These can be refactored to clean up duplicated source code.

The text was updated successfully, but these errors were encountered:

jmbills self-assigned this

Contributor Author

jmbills commented Aug 8, 2023

It looks like in libpam 1.5.3, pam_pwhistory will move to a separate /etc/security/pwhistory.conf file like pam_faillock uses: https://github.com/linux-pam/linux-pam/blob/bf07335a19d6192adaf4b1a817d2101ee0bad134/modules/pam_pwhistory/pwhistory.conf.

After that update, we can update pwhistory to use the getPamModuleConfValue() function, and just delete getPamModuleArgValue().

geissonator closed this as completed in

3b280ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment