Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download file in document list #3760

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jonathan-rohde
Copy link
Contributor

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Re-add the download button as link
  • Use FileAPI
  • Store file-id in meta data of documents
  • Only show download button, if file-id is available

Added

  • Download button for documents

Additional Information

  • It might make sense to migrate the documents to the files API sooner or later. The files table also contains all the inline uploaded files, which are not available in the documents table
  • If backend and frontend running on different hosts/ports than the browser might show a preview instead of downloading the file.

@drupol
Copy link

drupol commented Jul 15, 2024

Cool feature, I was looking for something similar.

Do you think you could also add a new column in the table with the date the document was added?

@tjbck tjbck marked this pull request as draft July 15, 2024 17:08
@drupol
Copy link

drupol commented Jul 22, 2024

@jonathan-rohde WDYT ^^

@jonathan-rohde
Copy link
Contributor Author

Sounds good to me to add that info in general to the view.
But I do not see it necessarily part of this PR, could be another one.

Furthermore I am currently not updating the PR as the document view is changing and I first want to await those changes to update my code.

@drupol
Copy link

drupol commented Jul 23, 2024

Cool ! Thank you for your answer, make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants