Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add scroll to admin/user settings tabs #3636

Merged
merged 2 commits into from
Jul 6, 2024
Merged

fix: add scroll to admin/user settings tabs #3636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
8381346
enh: add sideways scrolling to settings tabs container
Peter-De-Ath Jul 5, 2024
c3c15cb
refac
tjbck Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
enh: add sideways scrolling to settings tabs container
  • Loading branch information
@Peter-De-Ath
Peter-De-Ath committed Jul 5, 2024
commit 838134637818ae64127bcb27a9208b0466b438d4
17 changes: 15 additions & 2 deletions src/lib/components/admin/Settings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 1,5 @@
<script>
import { getContext, tick } from 'svelte';
import { getContext, tick, onMount } from 'svelte';
import { toast } from 'svelte-sonner';

import Database from './Settings/Database.svelte';
Expand All @@ -21,11 21,24 @@
const i18n = getContext('i18n');

let selectedTab = 'general';

onMount(() => {
const containerElement = document.getElementById('admin-settings-tabs-container');

if (containerElement) {
containerElement.addEventListener('wheel', function (event) {
if (event.deltaY !== 0) {
// Adjust horizontal scroll position based on vertical scroll
containerElement.scrollLeft = event.deltaY;
}
});
}
});
</script>

<div class="flex flex-col lg:flex-row w-full h-full py-2 lg:space-x-4">
<div
class="tabs flex flex-row overflow-x-auto space-x-1 max-w-full lg:space-x-0 lg:space-y-1 lg:flex-col lg:flex-none lg:w-44 dark:text-gray-200 text-xs text-left scrollbar-none"
id="admin-settings-tabs-container" class="tabs flex flex-row overflow-x-auto space-x-1 max-w-full lg:space-x-0 lg:space-y-1 lg:flex-col lg:flex-none lg:w-44 dark:text-gray-200 text-xs text-left scrollbar-none"
>
<button
class="px-2.5 py-2.5 min-w-fit rounded-lg flex-1 lg:flex-none flex text-right transition {selectedTab ===
Expand Down
29 changes: 28 additions & 1 deletion src/lib/components/chat/SettingsModal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 1,5 @@
<script lang="ts">
import { getContext } from 'svelte';
import { getContext, afterUpdate } from 'svelte';
import { toast } from 'svelte-sonner';
import { models, settings, user } from '$lib/stores';

Expand Down Expand Up @@ -34,6 34,32 @@
};

let selectedTab = 'general';

// Function to handle sideways scrolling
const handleSidewaysScroll = (event) => {
const settingsTabsContainer = document.getElementById('settings-tabs-container');
if (settingsTabsContainer) {
event.preventDefault(); // Prevent default vertical scrolling
settingsTabsContainer.scrollLeft = event.deltaY; // Scroll sideways
}
};

// Use afterUpdate to add the event listener after the modal is confirmed to be visible
// and remove it when the modal is closed
afterUpdate(() => {
if (show) {
const settingsTabsContainer = document.getElementById('settings-tabs-container');
if (settingsTabsContainer) {
settingsTabsContainer.addEventListener('wheel', handleSidewaysScroll);
}
} else {
const settingsTabsContainer = document.getElementById('settings-tabs-container');
if (settingsTabsContainer) {
settingsTabsContainer.removeEventListener('wheel', handleSidewaysScroll);
}
}
});

</script>

<Modal bind:show>
Expand Down Expand Up @@ -61,6 87,7 @@

<div class="flex flex-col md:flex-row w-full p-4 md:space-x-4">
<div
id="settings-tabs-container"
class="tabs flex flex-row overflow-x-auto space-x-1 md:space-x-0 md:space-y-1 md:flex-col flex-1 md:flex-none md:w-40 dark:text-gray-200 text-xs text-left mb-3 md:mb-0"
>
<button
Expand Down
Loading