Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Collapsible component #3631

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

ricky-davis
Copy link
Contributor

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Provides a custom built collapsible component which can be used instead of the bits-ui provided component. The bits-ui component causes page crashing when the component is opened/closed while the content is still being modified.

Added

  • New custom Collapsible component.

Changed

  • Updated WebSearchResults to use new Collapsible component.

Fixed

  • Fixes issue with opening/closing collapsible while content is still being modified.

@tjbck
Copy link
Contributor

tjbck commented Jul 6, 2024

Thanks!

@tjbck tjbck merged commit 97a8491 into open-webui:dev Jul 6, 2024
2 of 5 checks passed
@silentoplayz
Copy link
Collaborator

I recently put the new custom collapsible component for WebSearchResults through its paces, conducting a thorough stress test using an autoclicker. I'm pleased to report that it performed extremely well, even under intense load conditions, including a high-volume simulation of interactions with the Searched x sites dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants