fix: RegExp "invalid group specifier name" exception on Safari < 16.4 #3564
1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
This change has been reverted in dev as this broke compatibility with OpenAI models. Feel free to reopen the PR again after THOROUGHLY testing the changes, thanks! |
|
Apologize for the oversight in my previous submission. It doesn't handle empty strings properly, which can occur quite often when token generation is slow. Here's the updated one: let sentences = text.match(/[^\.!\?] [\.!\?]*|. /g) || [];I've tested it in both UI and browser console, and it works as expected. Here are the test results: > let text = "Hello, there! What's this? This is a string."
> text.match(/[^\.!\?] [\.!\?]*|. /g) || [ "" ]
[ 'Hello, there!', " What's this?", ' This is a string.' ]
> text.split(/(?<=[.!?])\s /)
[ 'Hello, there!', "What's this?", 'This is a string.' ]
> text = ""
> text.match(/[^\.!\?] [\.!\?]*|. /g) || [ "" ]
[ '' ]
> text.split(/(?<=[.!?])\s /)
[ '' ]
> text = `Multiple
... lines.
... !`
> text.match(/[^\.!\?] [\.!\?]*|. /g) || [ "" ]
[ 'Multiple\nlines.', '\n!' ]
> text.split(/(?<=[.!?])\s /)
[ 'Multiple\nlines.', '!' ]Even though leading whitespace characters exist, they will be trimmed later by As this PR has already been merged, I'm unable to reopen it. You could commit this directly. Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
This PR fixed the issue of regex exception for Safari before 16.4 (iOS 16.4), where regex lookbehind syntax is not supported. Before this change, devices that are not supported by or updated to iOS 16.4 or later are unable to use Open WebUI chat, e.g. iPhone 7.
Fixed
Additional Information
This issue was first observed in Open WebUI 0.3.5.
For more information, see discussion here: #3372 (comment)
Prior art: