Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: case insensitive prompt/models selection chat input #3437

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

silentoplayz
Copy link
Collaborator

@silentoplayz silentoplayz commented Jun 25, 2024

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This pull request makes both model name searches and prompt searches case-insensitive by converting all text to lowercase before comparing them. This change improves the user experience by allowing users to search for models and prompts regardless of their capitalization.

Changed

  • A line code was modified to convert both model names and prompts to lowercase before comparing them, making searches case-insensitive.

Additional Information

  • This change improves the user experience by allowing users to search for models and prompts regardless of their capitalization.

Note: I could not test this PR on my own machine, as I have issues in VSCode with my conda environment (I might've borked something or something got borked from pulling 350 changes since last using my VSCode install of Open WebUI, not entirely sure). I've also tried in a new conda environment and had the same issues, but by now, maybe my base environment for Conda is borked, and I only have myself to blame if that's the case.

feat: case-insensitive prompt search
feat: case-insensitive @model-name search
@silentoplayz
Copy link
Collaborator Author

silentoplayz commented Jun 25, 2024

This PR was inspired by and is related to #3407.

@tjbck
Copy link
Contributor

tjbck commented Jun 25, 2024

LGTM, Thanks!

@tjbck tjbck merged commit b0ed8de into open-webui:dev Jun 25, 2024
4 of 5 checks passed
@silentoplayz silentoplayz deleted the patch-1 branch June 25, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants