feat: hide all API keys by default in admin settings #3418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
dev
branch.Changelog Entry
Description
Hide all API keys in Admin Settings by default by setting the
input
type topassword
, and provide a button to unhide the keys.One side effect that might require some hacks to solve is that Chrome will ask to save the API keys as passwords due to
type=password
. It's probably worth making aToggleableSensitiveInput
component that can be reused.The
{...{ type: showSTTKey ? 'text' : 'password' }}
construction is used because Svelte disallows the use of abind:value
and a dynamictype
.Changed
Screenshots or Videos