Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/case insensitive tag selection #3407

Merged

Conversation

jonathan-rohde
Copy link
Contributor

@jonathan-rohde jonathan-rohde commented Jun 24, 2024

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Currently the selection of file/tag/collection by starting message with '#' is case sensitive. Which means that a user has to remember how a certain value has been stored.
With the change the search is case insensitive.

Changed

  • Ignore cases, when searching documents/tags/collection in Message Input

@jonathan-rohde jonathan-rohde changed the base branch from main to dev June 24, 2024 14:50
@jonathan-rohde jonathan-rohde changed the title Feat/case insensitive tag selection feat/case insensitive tag selection Jun 24, 2024
@jonathan-rohde jonathan-rohde marked this pull request as ready for review June 24, 2024 14:50
@tjbck
Copy link
Contributor

tjbck commented Jun 25, 2024

LGTM, Thanks!

@tjbck tjbck merged commit 09082a0 into open-webui:dev Jun 25, 2024
5 checks passed
@jonathan-rohde jonathan-rohde deleted the feat/case-insensitive-tag-selection branch June 25, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants