Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for Stable Diffusion 3 alongside more extensive ComfyUI configuration #3219

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

JohnTheNerd
Copy link
Contributor

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

added Stable Diffusion 3 support alongside ComfyUI configuration.

this commit adds four environment variables:

  • COMFYUI_CFG_SCALE
  • COMFYUI_SAMPLER
  • COMFYUI_SCHEDULER
  • COMFYUI_SD3

Added

The above mentioned environment variables, alongside Stable Diffusion 3 support.

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

closes #1459 alongside addressing the top comment (for ComfyUI only, as I do not have an AUTOMATIC1111 setup to test with). also closes #1958 (again, for ComfyUI only, since afaik AUTOMATIC1111 doesn't even support SD3).

Security

N/A

Breaking Changes

No breaking changes, because if the environment variable does not exist, we fall back to the original behavior.


Additional Information

All three of the changes I wrote in the past few hours are built together in the Docker image ghcr.io/johnthenerd/open-webui:comfyui-test3 and I am currently running them in my homelab without any issues. Tested with and without the new environment variables.

Docs at open-webui/docs#119

Screenshots or Videos

SD3 with everything set to what is recommended in the documentation (updated the example screenshot since the last PR, because this is so much nicer):

image

this commit adds four environment variables:

- COMFYUI_CFG_SCALE
- COMFYUI_SAMPLER
- COMFYUI_SCHEDULER
- COMFYUI_SD3 (merely setting this at all will enable SD3 mode)
@tjbck
Copy link
Contributor

tjbck commented Jun 16, 2024

LGTM!

@tjbck tjbck merged commit f76a569 into open-webui:dev Jun 16, 2024
@JohnTheNerd JohnTheNerd deleted the comfyui-configuration branch June 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants